From 643460f392d8ddb650beb490581c244cc920d2bc Mon Sep 17 00:00:00 2001 From: OverflowNarhoym Date: Tue, 22 Feb 2022 19:07:11 +0100 Subject: [PATCH] Replaced magic numbers with constants --- Assets/Scripts/Player/PlayerController.cs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Assets/Scripts/Player/PlayerController.cs b/Assets/Scripts/Player/PlayerController.cs index 2da7c2c..917ec4d 100644 --- a/Assets/Scripts/Player/PlayerController.cs +++ b/Assets/Scripts/Player/PlayerController.cs @@ -14,6 +14,9 @@ namespace Player private const float MaxSpeed = 500.0f; private const float DefaultAirSpeed = 300.0f; private const float GravityScale = 5.0f; + private const float AccelerationScale = 40.0f; + private const float DecelerationScale = 60.0f; + private const float RespawnLimit = -60.0f; private const float FallMultiplier = 4.0f; private const float LowJumpMultiplier = 4.0f; @@ -110,7 +113,7 @@ namespace Player private void RespawnCheck() { - if (gameObject.transform.position.y < -100) + if (gameObject.transform.position.y < RespawnLimit) SceneManager.LoadScene(SceneManager.GetActiveScene().name); } @@ -164,14 +167,14 @@ namespace Player } if (!_isOnAir) - BaseSpeed += 40; + BaseSpeed += AccelerationScale; _playerRigidbody2D.velocity = new Vector2(BaseSpeed * _xAxisValue * Time.fixedDeltaTime, _playerRigidbody2D.velocity.y); } private void DecelerationAfterMoving() { - BaseSpeed -= 80; + BaseSpeed -= DecelerationScale; _playerRigidbody2D.velocity = new Vector2(BaseSpeed * (int)_orientation * Time.fixedDeltaTime, _playerRigidbody2D.velocity.y); if (BaseSpeed == 0)