Syntriax/Engine-Pong
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: renamed delegate type to be less confusing

Browse Source
This commit is contained in:
Syntriax 2025-06-01 11:28:14 +03:00
parent e27b825990
commit 1ff26f5be4
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Shared/Network/NetworkManager.cs
View File

@ -18,7 +18,7 @@ public class NetworkManager : UniverseObject, INetworkManager
private readonly Dictionary<Type, Dictionary<string, object>> clientPacketRouters = []; private readonly Dictionary<Type, Dictionary<string, object>> clientPacketRouters = [];
private readonly Dictionary<Type, Dictionary<string, object>> serverPacketRouters = []; private readonly Dictionary<Type, Dictionary<string, object>> serverPacketRouters = [];
private readonly List<(Type packetType, Delegate callback)> packetRetrievalDelegates = []; private readonly List<(Type packetType, Delegate @delegate)> packetRetrievalDelegates = [];
private readonly Dictionary<Type, MethodInfo> clearRoutesMethods = []; private readonly Dictionary<Type, MethodInfo> clearRoutesMethods = [];
private readonly Dictionary<Type, MethodInfo> registerPacketListenersMethods = []; private readonly Dictionary<Type, MethodInfo> registerPacketListenersMethods = [];
@ -52,10 +52,10 @@ public class NetworkManager : UniverseObject, INetworkManager
MethodInfo subscribeToPacketsMethod = typeof(INetworkCommunicator) MethodInfo subscribeToPacketsMethod = typeof(INetworkCommunicator)
.GetMethod(nameof(INetworkCommunicator.SubscribeToPackets), BindingFlags.NonPublic | BindingFlags.Public | BindingFlags.Instance)!; .GetMethod(nameof(INetworkCommunicator.SubscribeToPackets), BindingFlags.NonPublic | BindingFlags.Public | BindingFlags.Instance)!;
foreach ((Type packetType, Delegate callback) in packetRetrievalDelegates) foreach ((Type packetType, Delegate @delegate) in packetRetrievalDelegates)
{ {
MethodInfo genericSubscribeMethod = subscribeToPacketsMethod.MakeGenericMethod(packetType); MethodInfo genericSubscribeMethod = subscribeToPacketsMethod.MakeGenericMethod(packetType);
genericSubscribeMethod.Invoke(networkCommunicator, [callback]); genericSubscribeMethod.Invoke(networkCommunicator, [@delegate]);
} }
} }
@ -64,10 +64,10 @@ public class NetworkManager : UniverseObject, INetworkManager
MethodInfo unsubscribeFromPacketsMethod = typeof(INetworkCommunicator) MethodInfo unsubscribeFromPacketsMethod = typeof(INetworkCommunicator)
.GetMethod(nameof(INetworkCommunicator.UnsubscribeFromPackets), BindingFlags.NonPublic | BindingFlags.Public | BindingFlags.Instance)!; .GetMethod(nameof(INetworkCommunicator.UnsubscribeFromPackets), BindingFlags.NonPublic | BindingFlags.Public | BindingFlags.Instance)!;
foreach ((Type packetType, Delegate callback) in packetRetrievalDelegates) foreach ((Type packetType, Delegate @delegate) in packetRetrievalDelegates)
{ {
MethodInfo genericUnsubscribeMethod = unsubscribeFromPacketsMethod.MakeGenericMethod(packetType); MethodInfo genericUnsubscribeMethod = unsubscribeFromPacketsMethod.MakeGenericMethod(packetType);
genericUnsubscribeMethod.Invoke(networkCommunicator, [callback]); genericUnsubscribeMethod.Invoke(networkCommunicator, [@delegate]);
} }
} }
#endregion #endregion
@ -278,7 +278,7 @@ public class NetworkManager : UniverseObject, INetworkManager
private void CacheRegistrationMethods(Dictionary<Type, MethodInfo> registrationMethods, string methodName) private void CacheRegistrationMethods(Dictionary<Type, MethodInfo> registrationMethods, string methodName)
{ {
MethodInfo registerPacketMethod = typeof(NetworkManager).GetMethod(methodName, BindingFlags.NonPublic | BindingFlags.Static)!; MethodInfo registerPacketMethod = typeof(NetworkManager).GetMethod(methodName, BindingFlags.NonPublic | BindingFlags.Static)!;
foreach ((Type packetType, Delegate callback) in packetRetrievalDelegates) foreach ((Type packetType, Delegate @delegate) in packetRetrievalDelegates)
{ {
MethodInfo genericMethod = registerPacketMethod.MakeGenericMethod(packetType); MethodInfo genericMethod = registerPacketMethod.MakeGenericMethod(packetType);
registrationMethods.Add(packetType, genericMethod); registrationMethods.Add(packetType, genericMethod);