fix: UnAssign Problems

Engine.Core/Abstract/Assignable/IAssignable.cs

@@ -1,6 +1,22 @@
+using System;
+
 namespace Syntriax.Engine.Core.Abstract;
 
 /// <summary>
 /// Indicates the class implementing it has Assignable fields that are necessary for the engine to work properly.
 /// </summary>
-public interface IAssignable { }
+public interface IAssignable
+{
+    /// <summary>
+    /// Callback triggered when the <see cref="IAssignable"/>'s fields are unassigned and completely ready to recycle.
+    /// </summary> 
+    Action<IAssignable>? OnUnassigned { get; set; }
+
+    /// <summary>
+    /// Unassign <see cref="IAssignable"/>'s all fields and make it ready to recycle.
+    /// </summary>
+    /// <returns> 
+    /// <see cref="true"/>, if the fields are unsigned successfully, <see cref="false"/> if not.
+    /// </returns>
+    bool Unassign();
+}

Engine.Core/Abstract/IEntity.cs

@@ -1,5 +1,5 @@
 namespace Syntriax.Engine.Core.Abstract;
 
-public interface IEntity : IAssignableStateEnable
+public interface IEntity : IInitialize, IAssignableStateEnable
 {
 }

Engine.Core/Abstract/IInitialize.cs

@@ -2,7 +2,7 @@ using System;
 
 namespace Syntriax.Engine.Core.Abstract;
 
-public interface IInitialize : IEntity
+public interface IInitialize
 {
     Action<IInitialize>? OnInitialized { get; set; }
     Action<IInitialize>? OnFinalized { get; set; }

Engine.Core/Behaviour.cs

@@ -1,4 +1,5 @@
 using System;
+
 using Syntriax.Engine.Core.Abstract;
 using Syntriax.Engine.Core.Exceptions;
 
@@ -6,6 +7,7 @@ namespace Syntriax.Engine.Core;
 
 public abstract class Behaviour : IBehaviour
 {
+    public Action<IAssignable>? OnUnassigned { get; set; } = null;
     public Action<IAssignableStateEnable>? OnStateEnableAssigned { get; set; } = null;
     public Action<IAssignableBehaviourController>? OnBehaviourControllerAssigned { get; set; } = null;
 
@@ -54,7 +56,7 @@ public abstract class Behaviour : IBehaviour
 
     public bool Assign(IStateEnable stateEnable)
     {
-        if (_initialized)
+        if (Initialized)
             return false;
 
         _stateEnable = stateEnable;
@@ -65,7 +67,7 @@ public abstract class Behaviour : IBehaviour
 
     public bool Assign(IBehaviourController behaviourController)
     {
-        if (_behaviourController is not null)
+        if (Initialized)
             return false;
 
         _behaviourController = behaviourController;
@@ -73,6 +75,18 @@ public abstract class Behaviour : IBehaviour
         return true;
     }
 
+    public bool Unassign()
+    {
+        if (Initialized)
+            return false;
+
+        _stateEnable = null!;
+        _behaviourController = null!;
+
+        OnUnassigned?.Invoke(this);
+        return true;
+    }
+
     public bool Initialize()
     {
         if (Initialized)
@@ -90,9 +104,6 @@ public abstract class Behaviour : IBehaviour
         if (!Initialized)
             return false;
 
-        _behaviourController = null!;
-        _stateEnable = null!;
-
         Initialized = false;
         return true;
     }

Engine.Core/BehaviourController.cs

@@ -15,6 +15,7 @@ public class BehaviourController : IBehaviourController
 
     public Action<IBehaviourController, IBehaviour>? OnBehaviourAdded { get; set; } = null;
     public Action<IBehaviourController, IBehaviour>? OnBehaviourRemoved { get; set; } = null;
+    public Action<IAssignable>? OnUnassigned { get; set; } = null;
     public Action<IAssignableGameObject>? OnGameObjectAssigned { get; set; } = null;
 
 
@@ -87,7 +88,7 @@ public class BehaviourController : IBehaviourController
 
     public bool Assign(IGameObject gameObject)
     {
-        if (_gameObject is not null)
+        if (GameObject is not null && GameObject.Initialized)
             return false;
 
         _gameObject = gameObject;
@@ -95,6 +96,16 @@ public class BehaviourController : IBehaviourController
         return true;
     }
 
+    public bool Unassign()
+    {
+        if (GameObject is not null && GameObject.Initialized)
+            return false;
+
+        _gameObject = null!;
+        OnUnassigned?.Invoke(this);
+        return true;
+    }
+
     public void Update(GameTime gameTime)
     {
         if (!GameObject.StateEnable.Enabled)

Engine.Core/BehaviourOverride.cs

@@ -14,8 +14,12 @@ public abstract class BehaviourOverride : Behaviour
     {
         OnInitialized += OnInitialize;
         OnFinalized += OnFinalize;
+        OnUnassigned += OnUnassign;
     }
 
+    protected virtual void OnUnassign() { }
+    private void OnUnassign(IAssignable assignable) => OnUnassign();
+
     protected virtual void OnInitialize() { }
     private void OnInitialize(IInitialize _)
     {

Engine.Core/Behaviours/DrawableBehaviour.cs

@@ -32,11 +32,11 @@ public class DrawableSpriteBehaviour : Behaviour, IDrawBehaviour, IAssignableSpr
 
     public bool Assign(ISprite sprite)
     {
-        if (_sprite is not null)
-            return false;
-
         _sprite = sprite;
         OnSpriteAssigned?.Invoke(this);
         return true;
     }
+
+    public DrawableSpriteBehaviour() => OnUnassigned += OnUnassign;
+    private void OnUnassign(IAssignable assignable) => _sprite = null!;
 }

Engine.Core/Engine.Core.csproj

@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
-    <ImplicitUsings>enable</ImplicitUsings>
+    <ImplicitUsings>false</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>
 

Engine.Core/GameManager.cs

@@ -1,15 +1,20 @@
+using System;
+using System.Collections.Generic;
+
 using Microsoft.Xna.Framework;
 using Microsoft.Xna.Framework.Graphics;
 
 using Syntriax.Engine.Core.Abstract;
+using Syntriax.Engine.Core.Exceptions;
 using Syntriax.Engine.Core.Factory;
 
 namespace Syntriax.Engine.Core;
 
-public class GameManager : IInitialize
+public class GameManager : IEntity
 {
     public Action<IInitialize>? OnInitialized { get; set; } = null;
     public Action<IInitialize>? OnFinalized { get; set; } = null;
+    public Action<IAssignable>? OnUnassigned { get; set; } = null;
     public Action<IAssignableStateEnable>? OnStateEnableAssigned { get; set; } = null;
 
 
@@ -63,6 +68,8 @@ public class GameManager : IInitialize
         if (Initialized)
             return false;
 
+        NotAssignedException.Check(this, StateEnable);
+
         foreach (var gameObject in GameObjects)
             gameObject.Initialize();
 
@@ -84,7 +91,7 @@ public class GameManager : IInitialize
 
     public bool Assign(IStateEnable stateEnable)
     {
-        if (_stateEnable is not null)
+        if (Initialized)
             return false;
 
         _stateEnable = stateEnable;
@@ -92,6 +99,16 @@ public class GameManager : IInitialize
         return true;
     }
 
+    public bool Unassign()
+    {
+        if (Initialized)
+            return false;
+
+        _stateEnable = null!;
+        OnUnassigned?.Invoke(this);
+        return true;
+    }
+
     public void Update(GameTime time)
     {
         foreach (var gameObject in GameObjects)

Engine.Core/GameObject.cs

@@ -11,6 +11,7 @@ public class GameObject : IGameObject
 {
     public Action<IAssignableStateEnable>? OnStateEnableAssigned { get; set; } = null;
     public Action<IAssignableTransform>? OnTransformAssigned { get; set; } = null;
+    public Action<IAssignable>? OnUnassigned { get; set; } = null;
     public Action<IAssignableBehaviourController>? OnBehaviourControllerAssigned { get; set; } = null;
 
     public Action<IEntity>? OnNameChanged { get; set; } = null;
@@ -92,17 +93,13 @@ public class GameObject : IGameObject
             behaviour => behaviour.Finalize()
         );
 
-        _transform = null!;
-        _behaviourController = null!;
-        _stateEnable = null!;
-
         Initialized = false;
         return true;
     }
 
     public bool Assign(IStateEnable stateEnable)
     {
-        if (_stateEnable is not null)
+        if (Initialized)
             return false;
 
         _stateEnable = stateEnable;
@@ -112,7 +109,7 @@ public class GameObject : IGameObject
 
     public bool Assign(ITransform transform)
     {
-        if (_transform is not null)
+        if (Initialized)
             return false;
 
         _transform = transform;
@@ -122,7 +119,7 @@ public class GameObject : IGameObject
 
     public bool Assign(IBehaviourController behaviourController)
     {
-        if (_behaviourController is not null)
+        if (Initialized)
             return false;
 
         _behaviourController = behaviourController;
@@ -130,6 +127,19 @@ public class GameObject : IGameObject
         return true;
     }
 
+    public bool Unassign()
+    {
+        if (Initialized)
+            return false;
+
+        _stateEnable = null!;
+        _transform = null!;
+        _behaviourController = null!;
+
+        OnUnassigned?.Invoke(this);
+        return true;
+    }
+
     public GameObject() { OnBehaviourControllerAssigned += ConnectBehaviourController; }
     private void ConnectBehaviourController(IAssignableBehaviourController controller)
     {

Engine.Core/StateEnable.cs

@@ -6,6 +6,7 @@ namespace Syntriax.Engine.Core;
 
 public class StateEnable : IStateEnable
 {
+    public Action<IAssignable>? OnUnassigned { get; set; } = null;
     public Action<IAssignableEntity>? OnEntityAssigned { get; set; } = null;
     public Action<IStateEnable>? OnEnabledChanged { get; set; } = null;
 
@@ -29,11 +30,21 @@ public class StateEnable : IStateEnable
 
     public bool Assign(IEntity entity)
     {
-        if (_entity is not null)
+        if (_entity is not null && _entity.Initialized)
             return false;
 
         _entity = entity;
         OnEntityAssigned?.Invoke(this);
         return true;
     }
+
+    public bool Unassign()
+    {
+        if (_entity is null)
+            return false;
+
+        _entity = null!;
+        OnUnassigned?.Invoke(this);
+        return true;
+    }
 }

Engine.Input/KeyboardInputsBehaviour.cs

@@ -59,16 +59,26 @@ public class KeyboardInputsBehaviour : BehaviourOverride, IKeyboardInputs
         for (int i = 0; i < cachePressedCurrentlyCount; i++)
         {
             Keys currentlyPressedKey = cachePressedCurrently[i];
-            if (!WasPressed(currentlyPressedKey))
+
-                if (OnPressed.TryGetValue(currentlyPressedKey, out var action))
+            if (!OnPressed.TryGetValue(currentlyPressedKey, out var action))
+                continue;
+
+            if (WasPressed(currentlyPressedKey))
+                continue;
+
             action.Invoke(this, currentlyPressedKey);
         }
 
         for (int i = 0; i < cachePressedPreviouslyCount; i++)
         {
             Keys previouslyPressedKey = cachePressedPreviously[i];
-            if (!IsPressed(previouslyPressedKey))
+
-                if (OnReleased.TryGetValue(previouslyPressedKey, out var action))
+            if (!OnReleased.TryGetValue(previouslyPressedKey, out var action))
+                continue;
+
+            if (IsPressed(previouslyPressedKey))
+                continue;
+
             action.Invoke(this, previouslyPressedKey);
         }