Syntriax/Engine-Pong
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf: packet listener methods are now cached for performance

Browse Source
This commit is contained in:
Syntriax
2025-05-26 22:09:40 +03:00
parent 29829bbaa6
commit bddf00ce7a
2 changed files with 27 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Engine

Submodule Engine updated: 2df41e1881...8f8558a262

56
Shared/Network/NetworkManager.cs
View File

@@ -28,8 +28,8 @@ public class NetworkManager : UniverseObject, INetworkManager
}
}
private readonly Dictionary<Type, Dictionary<string, object>> clientPacketListeners = [];
private readonly Dictionary<Type, Dictionary<string, object>> serverPacketListeners = [];
private readonly Dictionary<Type, Dictionary<string, PacketListenerData>> clientPacketListeners = [];
private readonly Dictionary<Type, Dictionary<string, PacketListenerData>> serverPacketListeners = [];
private readonly Dictionary<string, INetworkEntity> _networkEntities = [];
public IReadOnlyDictionary<string, INetworkEntity> NetworkEntities => _networkEntities;
@@ -98,39 +98,27 @@ public class NetworkManager : UniverseObject, INetworkManager
if (entityDataPacket is IEntityNetworkPacket entityPacket)
{
if (networkCommunicator is INetworkCommunicatorClient)
if (clientPacketListeners.TryGetValue(packetType, out Dictionary<string, object>? clientListeners))
if (clientListeners.TryGetValue(entityPacket.EntityId, out object? clientListener))
{
MethodInfo clientListenerReceiveMethod = typeof(IPacketListenerClient<>).MakeGenericType(packetType).GetMethods().First(m => m.Name == nameof(IPacketListenerClient<T>.OnClientPacketArrived));
clientListenerReceiveMethod.Invoke(clientListener, [entityDataPacket]);
}
if (clientPacketListeners.TryGetValue(packetType, out Dictionary<string, PacketListenerData>? clientListeners))
if (clientListeners.TryGetValue(entityPacket.EntityId, out PacketListenerData clientListenerData))
clientListenerData.ListenerMethod.Invoke(clientListenerData.Object, [entityDataPacket]);
if (networkCommunicator is INetworkCommunicatorServer)
if (serverPacketListeners.TryGetValue(packetType, out Dictionary<string, object>? serverListeners))
if (serverListeners.TryGetValue(entityPacket.EntityId, out object? serverListener))
{
MethodInfo serverListenerReceiveMethod = typeof(IPacketListenerServer<>).MakeGenericType(packetType).GetMethods().First(m => m.Name == nameof(IPacketListenerServer<T>.OnServerPacketArrived));
serverListenerReceiveMethod.Invoke(serverListener, [entityDataPacket, fromClientId]);
}
if (serverPacketListeners.TryGetValue(packetType, out Dictionary<string, PacketListenerData>? serverListeners))
if (serverListeners.TryGetValue(entityPacket.EntityId, out PacketListenerData serverListenerData))
serverListenerData.ListenerMethod.Invoke(serverListenerData.Object, [entityDataPacket, fromClientId]);
return;
}
if (networkCommunicator is INetworkCommunicatorClient)
if (clientPacketListeners.TryGetValue(packetType, out Dictionary<string, object>? clientListeners))
{
MethodInfo clientListenerReceiveMethod = typeof(IPacketListenerClient<>).MakeGenericType(packetType).GetMethods().First(m => m.Name == nameof(IPacketListenerClient<T>.OnClientPacketArrived));
foreach ((string id, object clientListener) in clientListeners)
clientListenerReceiveMethod.Invoke(clientListener, [entityDataPacket]);
}
if (clientPacketListeners.TryGetValue(packetType, out Dictionary<string, PacketListenerData>? clientListeners))
foreach ((string id, PacketListenerData clientListenerData) in clientListeners)
clientListenerData.ListenerMethod.Invoke(clientListenerData.Object, [entityDataPacket]);
if (networkCommunicator is INetworkCommunicatorServer)
if (serverPacketListeners.TryGetValue(packetType, out Dictionary<string, object>? serverListeners))
{
MethodInfo serverListenerReceiveMethod = typeof(IPacketListenerServer<>).MakeGenericType(packetType).GetMethods().First(m => m.Name == nameof(IPacketListenerServer<T>.OnServerPacketArrived));
foreach ((string id, object serverListener) in serverListeners)
serverListenerReceiveMethod.Invoke(serverListener, [entityDataPacket, fromClientId]);
}
if (serverPacketListeners.TryGetValue(packetType, out Dictionary<string, PacketListenerData>? serverListeners))
foreach ((string id, PacketListenerData serverListenerData) in serverListeners)
serverListenerData.ListenerMethod.Invoke(serverListenerData.Object, [entityDataPacket, fromClientId]);
}
private void OnCollected(IBehaviourCollector<INetworkEntity> sender, INetworkEntity behaviourCollected)
@@ -141,27 +129,29 @@ public class NetworkManager : UniverseObject, INetworkManager
foreach (Type clientListenerType in behaviourCollected.GetType().GetInterfaces().Where(i => i.IsGenericType && i.GetGenericTypeDefinition() == typeof(IPacketListenerClient<>)))
{
Type clientListenerParameterType = clientListenerType.GetGenericArguments().First();
MethodInfo clientListenerReceiveMethod = clientListenerType.GetMethods().First(m => m.Name == nameof(IPacketListenerClient<INetworkEntity>.OnClientPacketArrived));
if (!clientPacketListeners.TryGetValue(clientListenerParameterType, out Dictionary<string, object>? clientListeners))
if (!clientPacketListeners.TryGetValue(clientListenerParameterType, out Dictionary<string, PacketListenerData>? clientListeners))
{
clientListeners = [];
clientPacketListeners.Add(clientListenerParameterType, clientListeners);
}
clientListeners.Add(behaviourCollected.Id, behaviourCollected);
clientListeners.Add(behaviourCollected.Id, new(behaviourCollected, clientListenerReceiveMethod));
}
foreach (Type serverListenerType in behaviourCollected.GetType().GetInterfaces().Where(i => i.IsGenericType && i.GetGenericTypeDefinition() == typeof(IPacketListenerServer<>)))
{
Type serverListenerParameterType = serverListenerType.GetGenericArguments().First();
MethodInfo serverListenerReceiveMethod = serverListenerType.GetMethods().First(m => m.Name == nameof(IPacketListenerServer<INetworkEntity>.OnServerPacketArrived));
if (!serverPacketListeners.TryGetValue(serverListenerParameterType, out Dictionary<string, object>? serverListeners))
if (!serverPacketListeners.TryGetValue(serverListenerParameterType, out Dictionary<string, PacketListenerData>? serverListeners))
{
serverListeners = [];
serverPacketListeners.Add(serverListenerParameterType, serverListeners);
}
serverListeners.Add(behaviourCollected.Id, behaviourCollected);
serverListeners.Add(behaviourCollected.Id, new(behaviourCollected, serverListenerReceiveMethod));
}
}
@@ -176,4 +166,10 @@ public class NetworkManager : UniverseObject, INetworkManager
_networkEntityCollector.Assign(universe);
NetworkCommunicator = this.GetRequiredUniverseObjectInParent<INetworkCommunicator>();
}
private record struct PacketListenerData(object Object, MethodInfo ListenerMethod)
{
public static implicit operator (object @object, MethodInfo listenerMethod)(PacketListenerData value) => (value.Object, value.ListenerMethod);
public static implicit operator PacketListenerData((object @object, MethodInfo listenerMethod) value) => new(value.@object, value.listenerMethod);
}
}